walterddr commented on code in PR #11937:
URL: https://github.com/apache/pinot/pull/11937#discussion_r1385969096
##########
pinot-query-planner/src/main/java/org/apache/calcite/rel/rules/PinotJoinToDynamicBroadcastRule.java:
##########
@@ -142,7 +142,7 @@ public boolean matches(RelOptRuleCall call) {
RelNode right = join.getRight() instanceof HepRelVertex ? ((HepRelVertex)
join.getRight()).getCurrentRel()
: join.getRight();
return left instanceof Exchange && right instanceof Exchange
- && PinotRuleUtils.noExchangeInSubtree(left.getInput(0))
+ && PinotRuleUtils.canPushDynamicBroadcastToLeaf(left.getInput(0))
Review Comment:
yes i think this is in the TODO item for this function. unfortunately,
there's not too much we can do here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]