Jackie-Jiang commented on code in PR #12058:
URL: https://github.com/apache/pinot/pull/12058#discussion_r1408566632
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##########
@@ -122,7 +122,8 @@ public QueryEnvironment(TypeFactory typeFactory,
CalciteSchema rootSchema, Worke
// SUB-QUERY Threshold is useless as we are encoding all IN clause
in-line anyway
.withInSubQueryThreshold(Integer.MAX_VALUE)
.addRelBuilderConfigTransform(c -> c.withPushJoinCondition(true))
- .addRelBuilderConfigTransform(c -> c.withAggregateUnique(true)))
+ .addRelBuilderConfigTransform(c -> c.withAggregateUnique(true))
+ .addRelBuilderConfigTransform(c ->
c.withPruneInputOfAggregate(false)))
Review Comment:
(minor) Can we chain them as `.addRelBuilderConfigTransform(c ->
c.withPushJoinCondition(true).withAggregateUnique(true).withPruneInputOfAggregate(false))`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
