ege-st commented on PR #12151: URL: https://github.com/apache/pinot/pull/12151#issuecomment-1860961248
> > By the way, besides unit tests, were you able to do a manual test and see what happens when Pinot is running and this error happens? > > No I did not. Do I have to implement an integration test as well? For the manual test: probably best to do a simple one, Pinot's a complex system and I like to do quick manual tests after my unit tests just to make sure there are no unexpected interactions. For the integration test: that's a good question, yeah, I think it'd be great to have integration tests to check that Pinot correctly handles invalid inputs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
