xiangfu0 commented on code in PR #12182:
URL: https://github.com/apache/pinot/pull/12182#discussion_r1432039892
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -336,7 +337,7 @@ private RebalanceResult doRebalance(TableConfig
tableConfig, RebalanceConfig reb
// current instances as this is the best we can do, and can help the
table get out of this state.
// 2. Only check the segments to be moved because we don't need to
maintain available replicas for segments not
// being moved, including segments with all replicas OFFLINE (error
segments during consumption).
- Set<String> segmentsToMove =
SegmentAssignmentUtils.getSegmentsToMove(currentAssignment, targetAssignment);
Review Comment:
Why change this from set to list?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
