walterddr commented on code in PR #12194:
URL: https://github.com/apache/pinot/pull/12194#discussion_r1439698356
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/JsonAsyncHttpPinotClientTransport.java:
##########
@@ -70,7 +68,7 @@ public JsonAsyncHttpPinotClientTransport() {
}
public JsonAsyncHttpPinotClientTransport(Map<String, String> headers, String
scheme, String extraOptionString,
- boolean useMultistageEngine, @Nullable SSLContext sslContext,
ConnectionTimeouts connectionTimeouts,
+ boolean useMultistageEngine, @Nullable SslContext sslContext,
ConnectionTimeouts connectionTimeouts,
Review Comment:
since this is public API we might need to keep supporting both
javax.net.ssl.SSLContext and io.netty.handler.ssl.SslContext and mark the
former with deprecated annotation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
