walterddr commented on code in PR #12201:
URL: https://github.com/apache/pinot/pull/12201#discussion_r1442360960
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRunningQueryResource.java:
##########
@@ -153,7 +154,8 @@ public Map<String, Map<String, String>> getRunningQueries(
@ApiParam(value = "Timeout for brokers to return running queries")
@QueryParam("timeoutMs") @DefaultValue("3000")
int timeoutMs, @Context HttpHeaders httpHeaders) {
try {
- Map<String, List<InstanceInfo>> tableBrokers =
_pinotHelixResourceManager.getTableToLiveBrokersMapping();
+ Map<String, List<InstanceInfo>> tableBrokers = _pinotHelixResourceManager
+ .getTableToLiveBrokersMapping(Optional.empty());
Review Comment:
no need to change here. add a new overload in PinotHelixResourceManager
since it is a public API
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3977,7 +3977,8 @@ public TableStats getTableStats(String tableNameWithType)
{
* Returns map of tableName to list of live brokers
* @return Map of tableName to list of ONLINE brokers serving the table
*/
- public Map<String, List<InstanceInfo>> getTableToLiveBrokersMapping() {
+ public Map<String, List<InstanceInfo>>
getTableToLiveBrokersMapping(Optional<String> optionalTableName)
Review Comment:
keep both
```suggestion
public Map<String, List<InstanceInfo>> getTableToLiveBrokersMapping() {
return getTableToLiveBrokersMapping(null);
}
public Map<String, List<InstanceInfo>>
getTableToLiveBrokersMapping(@Nullable String optionalTableName) {
..
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
