walterddr commented on code in PR #12241:
URL: https://github.com/apache/pinot/pull/12241#discussion_r1445503392
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##########
@@ -562,6 +570,25 @@ private void handleUpsert(ImmutableSegment
immutableSegment) {
}
}
+ // Same as the SegmentLocks, but just for handleUpsert method to synchronize
threads doing segment replacement.
+ private static class UpsertSegmentLocks {
Review Comment:
this way we can extend more if we have to (just add one more static member).
sorry for the "abstract" comment, i realized that it was a static class
afterwards
we can even get ride of the static method and make the static member
variable public.. so instead of `SegmetnLocks.getUpsertLock(...)` it will just
be `UPSERT_LOCK.getLock(...)`. the constructor is private so there's no way to
use the public method except through the static members, but that's up to you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
