walterddr commented on code in PR #12259:
URL: https://github.com/apache/pinot/pull/12259#discussion_r1449210569
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/DistinctCountThetaSketchAggregationFunction.java:
##########
@@ -964,6 +964,14 @@ public List<ThetaSketchAccumulator>
extractAggregationResult(AggregationResultHo
@Override
public List<ThetaSketchAccumulator> extractGroupByResult(GroupByResultHolder
groupByResultHolder, int groupKey) {
List result = groupByResultHolder.getResult(groupKey);
+ if (result == null) {
Review Comment:
TODO: trying to figure out proper test cases with binary encoding that
actually can trigger this codepath.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
