KKcorps commented on code in PR #12214:
URL: https://github.com/apache/pinot/pull/12214#discussion_r1452023748
##########
pinot-spi/src/main/java/org/apache/pinot/spi/stream/StreamConfig.java:
##########
@@ -142,7 +143,10 @@ public StreamConfig(String tableNameWithType, Map<String,
String> streamConfigMa
}
_connectionTimeoutMillis = connectionTimeoutMillis;
- int fetchTimeoutMillis = DEFAULT_STREAM_FETCH_TIMEOUT_MILLIS;
+ // For Kinesis, we need to set a higher fetch timeout to avoid getting
stuck in empty records loop
+ int fetchTimeoutMillis =
+ !_consumerFactoryClassName.contains("KinesisConsumerFactory") ?
DEFAULT_STREAM_FETCH_TIMEOUT_MILLIS_KINESIS
Review Comment:
Yeah, I can't use 10min as default because it will affect how soon the data
is available in Pinot. We will just keep on waiting for kafka to return records
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
