gortiz commented on issue #12254: URL: https://github.com/apache/pinot/issues/12254#issuecomment-1893209647
TL;DR: 1. `IndexingConfig.whatever` (where whatever is related to a single column index): Is the oldest implementation and should be avoided. 2. `FieldConfig.indexType` and `FieldConfig.indexTypes` is the first try to have a common place to configure indexes, but ended up being inconsistent and wasn't able to provide a nice way to configure indexes. It should *strongly* be avoided. 3. `FieldConfig.indexes` is the new standard way to configure single column indexes. It is centralized (all indexes of the same column are in the same place), expressive (indexes can be configured with complex objects) and easy to maintain from developer perspective (if the object can be understood by Jackson, no code needs to be added to serialize/deserialize). 4. In general, we fail if a config is specified in more than one place (ie `IndexingConfig.whatever` and `FieldConfig.indexes`). In order to do so, we use `withExclusiveAlternative`. 5. In some cases (like here in dictionaries) it is very difficult to detect in code whether the `IndexingConfig.whatever` was used or not, so in these cases we use `withFallbackAlternative`, but then the order matters. In this case , **we should give priority to the new `FieldConfig.indexes` than the other options**. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
