gortiz commented on PR #12073: URL: https://github.com/apache/pinot/pull/12073#issuecomment-1893219156
> Out of the scope of this PR, will these regex increase the memory footprint of the metrics? I've been observing saw-shape memory usage on servers without query load, and suspecting that is caused by the metrics. #8232 listed some previous work to reduce the memory footprint, which might provide some insights. It is difficult to analyze why #8232 increased efficiency given it: 1. Doesn't seem to include the older rules (which seem to be hardcoded before #8232. 2. Adds one rule per metric but also adds cache. In the I would say it is quite more expensive to process hundreds of very large regexps with the same prefix than a couple of them with correct quantifiers. And it is obviously easier for us to write. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
