xiangfu0 commented on issue #10651: URL: https://github.com/apache/pinot/issues/10651#issuecomment-1896811342
I think env var: `PINOT_CONTROLLER_ADMIN_ACCESS_CONTROL_PRINCIPALS` should be map to `controller.admin.access.control.principals` in the config file. See: https://github.com/apache/pinot/blob/master/pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java @t0mpere can you add a test to ensure the configs passed along with env variables are override as expected? If the solution here is generic, then we can later on generalize the configs across all the pinot components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
