KKcorps commented on code in PR #12250:
URL: https://github.com/apache/pinot/pull/12250#discussion_r1460522423
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -514,6 +521,24 @@ public void removeSegment(IndexSegment segment) {
return;
}
}
+
+ if (_helixManager != null) {
+ try {
+ HelixDataAccessor dataAccessor = _helixManager.getHelixDataAccessor();
+ PropertyKey propertyKey =
dataAccessor.keyBuilder().idealStates(_tableNameWithType);
+ IdealState idealState = dataAccessor.getProperty(propertyKey);
+ if (!idealState.isEnabled()) {
Review Comment:
As discussed offline, that is not possible because disable flow only sets a
flag in ideal state and then helix takes over removing the segments
in drop flow, we have the control and actually pass a custom message to all
servers which then take over segment removal
we also can't stop table upsert metadata manager cause a disabled table can
be re-enabled as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
