walterddr commented on code in PR #12258:
URL: https://github.com/apache/pinot/pull/12258#discussion_r1462683329
##########
pinot-spi/src/main/java/org/apache/pinot/spi/eventlistener/query/PinotBrokerQueryEventListenerFactory.java:
##########
@@ -44,6 +50,8 @@ private PinotBrokerQueryEventListenerFactory() {
public synchronized static void init(PinotConfiguration
eventListenerConfiguration) {
// Initializes BrokerQueryEventListener.
initializeBrokerQueryEventListener(eventListenerConfiguration);
+ // Initializes request headers
+ initializeAllowlistQueryRequestHeaders(eventListenerConfiguration);
Review Comment:
it is likely wont work. the prefix for this factory init is
`EVENT_LISTENER_CONFIG_PREFIX="pinot.broker.event.listener"`
however the request header is associated with RequestContext which is
created in PinotClientRequest. --> seems like they shouldn't share the same
configuration prefix?
if so we probably should use `pinot.broker` as prefix instead of under event
listenser?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
