abhioncbr commented on issue #12190: URL: https://github.com/apache/pinot/issues/12190#issuecomment-1910822002
hey @ankitsultana, question: We have some of the places in the code where we throw exceptions as a HTTP response, for example [here](https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java#L194) or [here](https://github.com/apache/pinot/blob/master/pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotClientRequest.java#L198). For such scenario, in my understanding, we don't set any particular Error Code. Do you think using some general Error Code in such scenarios is a good idea? We can leverage [UNKNOWN_ERROR_CODE](https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/exception/QueryException.java#L84) or can introduce a new one say `FAILED_EXECUTION_ERROR_CODE`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
