klsince commented on code in PR #12351:
URL: https://github.com/apache/pinot/pull/12351#discussion_r1475184165
##########
pinot-server/src/main/java/org/apache/pinot/server/starter/helix/SegmentOnlineOfflineStateModelFactory.java:
##########
@@ -46,6 +50,13 @@
* 3. Delete an existed segment.
*/
public class SegmentOnlineOfflineStateModelFactory extends
StateModelFactory<StateModel> {
+ // NOTE: Helix might process CONSUMING -> DROPPED transition as 2 separate
transitions: CONSUMING -> OFFLINE followed
+ // by OFFLINE -> DROPPED. Use this cache to track the segments that just
went through CONSUMING -> OFFLINE transition
+ // to detect CONSUMING -> DROPPED transition.
+ // TODO: Check how Helix handle CONSUMING -> DROPPED transition and remove
this cache if it's not needed.
+ private final Cache<Pair<String, String>, Boolean>
_recentlyOffloadedConsumingSegments =
Review Comment:
How about move the cache into the tableDataMgr? Considering the key of the
map is pair<tableName, segmentName> anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
