Jackie-Jiang commented on code in PR #12360:
URL: https://github.com/apache/pinot/pull/12360#discussion_r1477116983
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -961,7 +961,7 @@ public String getTableAggregateValidDocIdMetadata(
@ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
@ApiParam(value = "A list of segments", allowMultiple = true)
@QueryParam("segmentNames")
List<String> segmentNames,
- @ApiParam(value = "Valid doc id type", example =
"SNAPSHOT|IN_MEMORY|IN_MEMORY_WITH_DELETE")
+ @ApiParam(value = "Valid doc id type (SNAPSHOT | IN_MEMORY |
IN_MEMORY_WITH_DELETE)")
@QueryParam("validDocIdsType") String validDocIdsType) {
Review Comment:
Can we directly take enum here?
##########
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##########
@@ -610,7 +614,7 @@ public String getValidDocIdMetadata(
public String getValidDocIdMetadata(
Review Comment:
Introduced in the previous PR. Can we change this to GET request? Maybe
change the path to "/tables/{tableNameWithType}/validDocIdsMetadata"
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -961,7 +961,7 @@ public String getTableAggregateValidDocIdMetadata(
@ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
@ApiParam(value = "A list of segments", allowMultiple = true)
@QueryParam("segmentNames")
List<String> segmentNames,
- @ApiParam(value = "Valid doc id type", example =
"SNAPSHOT|IN_MEMORY|IN_MEMORY_WITH_DELETE")
+ @ApiParam(value = "Valid doc id type (SNAPSHOT | IN_MEMORY |
IN_MEMORY_WITH_DELETE)")
Review Comment:
```suggestion
@ApiParam(value = "Valid doc ids type (SNAPSHOT | IN_MEMORY |
IN_MEMORY_WITH_DELETE)")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
