deemoliu commented on code in PR #12395: URL: https://github.com/apache/pinot/pull/12395#discussion_r1496151293
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ########## @@ -601,6 +604,46 @@ protected void handleOutOfOrderEvent(Object currentComparisonValue, Object recor } } + /** + * When we have to process a new segment, if there are comparison value ties for the same primary-key within the + * segment, then for Partial Upsert tables we need to make sure that the record location map is updated only + * for the latest version of the record. This is specifically a concern for Partial Upsert tables because Realtime Review Comment: where the version come from? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org