xiangfu0 commented on PR #12386: URL: https://github.com/apache/pinot/pull/12386#issuecomment-1956189662
> @xiangfu0 I parked the config name `pinot.timezone` under `CommonConstants`, not sure its the right place but I think it should be common for all pinot components ( contrller, broker, server, minion ). > > Another question I have is how does each component pick up relevant value from config ( for example `pinot.timezone` ). I did some diggings and seems like it points to `readControllerConfigFromFile` and `readControllerConfigFromFile` in org.apache.pinot.tools.utils.PinotConfigUtils` I feel what you've done which uses cluster config is a better choice here. Since we want this config to apply to all the components. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
