gortiz commented on code in PR #12227:
URL: https://github.com/apache/pinot/pull/12227#discussion_r1507164446
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/ModeAggregationFunction.java:
##########
@@ -467,7 +501,11 @@ public ColumnDataType getFinalResultColumnType() {
@Override
public Double extractFinalResult(Map<? extends Number, Long>
intermediateResult) {
if (intermediateResult.isEmpty()) {
- return DEFAULT_FINAL_RESULT;
+ if (_nullHandlingEnabled) {
Review Comment:
I'm adding a new test to show the result when all stored data is null
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
