gortiz commented on code in PR #12554:
URL: https://github.com/apache/pinot/pull/12554#discussion_r1513946123
##########
pinot-core/src/test/java/org/apache/pinot/core/startree/v2/BaseStarTreeV2Test.java:
##########
@@ -91,32 +91,35 @@ abstract class BaseStarTreeV2Test<R, A> {
private static final int NUM_SEGMENT_RECORDS = 100_000;
private static final int MAX_LEAF_RECORDS = RANDOM.nextInt(100) + 1;
- private static final String DIMENSION_D1 = "d1";
- private static final String DIMENSION_D2 = "d2";
+ private static final String DIMENSION_D1 = "d1__COLUMN_NAME";
Review Comment:
TBH I don't like this tests. It is very chaotic and difficult to read.
Having to apply these modifications in order to test that names with
underscores are not failing makes no sense. We should have a simple test method
testing that condition.
But it can be done in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
