Jackie-Jiang commented on code in PR #12392:
URL: https://github.com/apache/pinot/pull/12392#discussion_r1515232533
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -570,6 +572,107 @@ public static String[] split(String input, String
delimiter, int limit) {
return StringUtils.splitByWholeSeparator(input, delimiter, limit);
}
+ /**
+ * @param input an input string for prefix strings generations.
+ * @param maxlength the max length of the prefix strings for the string.
+ * @return generate an array of prefix strings of the string that are
shorter than the specified length.
+ */
+ @ScalarFunction
Review Comment:
You want to add alias `unique_prefixes`, same for other functions
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -570,6 +572,107 @@ public static String[] split(String input, String
delimiter, int limit) {
return StringUtils.splitByWholeSeparator(input, delimiter, limit);
}
+ /**
+ * @param input an input string for prefix strings generations.
+ * @param maxlength the max length of the prefix strings for the string.
+ * @return generate an array of prefix strings of the string that are
shorter than the specified length.
+ */
+ @ScalarFunction
Review Comment:
Do we need `unique` though? The prefixes will always be unique because they
all have different length
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -570,6 +572,107 @@ public static String[] split(String input, String
delimiter, int limit) {
return StringUtils.splitByWholeSeparator(input, delimiter, limit);
}
+ /**
+ * @param input an input string for prefix strings generations.
+ * @param maxlength the max length of the prefix strings for the string.
+ * @return generate an array of prefix strings of the string that are
shorter than the specified length.
+ */
+ @ScalarFunction
+ public static String[] uniquePrefixes(String input, int maxlength) {
+ ObjectSet<String> prefixSet = new ObjectLinkedOpenHashSet<>();
+ for (int prefixLength = 1; prefixLength <= maxlength && prefixLength <=
input.length(); prefixLength++) {
+ prefixSet.add(input.substring(0, prefixLength));
+ }
+ return prefixSet.toArray(new String[0]);
+ }
+
+ /**
+ * @param input an input string for prefix strings generations.
+ * @param maxlength the max length of the prefix strings for the string.
+ * @param prefix the prefix to be prepended to prefix strings generated.
e.g. '^' for regex matching
+ * @return generate an array of prefix matchers of the string that are
shorter than the specified length.
+ */
+ @ScalarFunction
+ public static String[] uniquePrefixesWithPrefix(String input, int maxlength,
String prefix) {
+ if (prefix == null) {
Review Comment:
In order to accept `null`, you want to annotate it as `nullableParameters`.
Please also annotate the parameter to be `@Nullable`
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/StringFunctions.java:
##########
@@ -570,6 +572,107 @@ public static String[] split(String input, String
delimiter, int limit) {
return StringUtils.splitByWholeSeparator(input, delimiter, limit);
}
+ /**
+ * @param input an input string for prefix strings generations.
+ * @param maxlength the max length of the prefix strings for the string.
+ * @return generate an array of prefix strings of the string that are
shorter than the specified length.
+ */
+ @ScalarFunction
+ public static String[] uniquePrefixes(String input, int maxlength) {
+ ObjectSet<String> prefixSet = new ObjectLinkedOpenHashSet<>();
Review Comment:
We don't need a set since all prefixes have different length. Same for other
functions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
