satishd commented on code in PR #12594:
URL: https://github.com/apache/pinot/pull/12594#discussion_r1517236753
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##########
@@ -572,6 +572,7 @@ private boolean processStreamEvents(MessageBatch
messagesAndOffsets, long idlePi
// Decode message
StreamDataDecoderResult decodedRow =
_streamDataDecoder.decode(messagesAndOffsets.getStreamMessage(index));
msgMetadata = messagesAndOffsets.getStreamMessage(index).getMetadata();
+ StreamPartitionMsgOffset messageOffset =
messagesAndOffsets.getNextStreamPartitionMsgOffsetAtIndex(index);
Review Comment:
It seems `getNextStreamPartitionMsgOffsetAtIndex` returns the offset of the
next message for the given index. Should not we use
`getMessageOffsetAtIndex(int index)` for getting the current message's offset
that we wanted to use in the error messages?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
