rohityadav1993 commented on code in PR #11983:
URL: https://github.com/apache/pinot/pull/11983#discussion_r1517352187
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -307,7 +309,7 @@ protected GenericRow doUpdateRecord(GenericRow record,
RecordInfo recordInfo) {
int currentDocId = recordLocation.getDocId();
if (currentQueryableDocIds == null ||
currentQueryableDocIds.contains(currentDocId)) {
_reusePreviousRow.init(currentSegment, currentDocId);
- _partialUpsertHandler.merge(_reusePreviousRow, record);
+ _partialUpsertHandler.merge(_reusePreviousRow, record,
_reuseMergerResult);
Review Comment:
The`_reuseMergerResult` map is defined in the context of a partition for a
consuming segment. If we move it to `PartialUpsertHandler` then we need to
modify `PartialUpsertHandler` to be initialised in
`BasePartitionUpsertMetadataManager` instead of
`BaseTableUpsertMetadataManager`. Moreover the `_reuseMergerResult` would have
to be made threadsafe across consuming segments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
