gortiz commented on code in PR #12673:
URL: https://github.com/apache/pinot/pull/12673#discussion_r1529883369
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java:
##########
@@ -230,7 +230,7 @@ public static String arrayElementAtString(String[] arr, int
idx) {
@ScalarFunction(names = {"array", "arrayValueConstructor"}, isVarArg = true)
public static Object arrayValueConstructor(Object... arr) {
- if (arr.length == 0) {
+ if (arr == null || arr.length == 0 || arr[0] == null) {
Review Comment:
Here we are changing the semantic, right? We are treating `[null]` in the
same way we treated `[]` in the past.
I would feel more confident with something like `if (arr == null ||
arr.length == 0)`, which is what we may wanted to do in the first place
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
