soumitra-st commented on code in PR #12722:
URL: https://github.com/apache/pinot/pull/12722#discussion_r1538337724
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -199,14 +199,19 @@ public void preloadSegments(IndexLoadingConfig
indexLoadingConfig) {
return;
}
// From now on, the _isPreloading flag is true until the segments are
preloaded.
+ long startTime = System.currentTimeMillis();
Review Comment:
It is not about precision rather correctness.
https://pradeesh-kumar.medium.com/java-system-nanotime-vs-system-currenttimemillis-604f59555561
is a good read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
