Jackie-Jiang commented on code in PR #12697:
URL: https://github.com/apache/pinot/pull/12697#discussion_r1552472334
##########
pinot-plugins/pinot-stream-ingestion/pinot-pulsar/src/main/java/org/apache/pinot/plugin/stream/pulsar/PulsarPartitionLevelConsumer.java:
##########
@@ -45,21 +45,21 @@
public class PulsarPartitionLevelConsumer extends
PulsarPartitionLevelConnectionHandler
implements PartitionGroupConsumer {
private static final Logger LOGGER =
LoggerFactory.getLogger(PulsarPartitionLevelConsumer.class);
- private final ExecutorService _executorService;
+
private final Reader _reader;
- private boolean _enableKeyValueStitch;
- public PulsarPartitionLevelConsumer(String clientId, StreamConfig
streamConfig,
- PartitionGroupConsumptionStatus partitionGroupConsumptionStatus) {
+ // TODO: Revisit the logic of using a separate executor to manage the
request timeout. Currently it is not thread safe
Review Comment:
It is handled within `PulsarUtils.buildPulsarStreamMessage()`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
