Jackie-Jiang commented on PR #12754: URL: https://github.com/apache/pinot/pull/12754#issuecomment-2038268789
> Are we sure we needed to copy the whole jj file? I'm not an expert here, but AFAIU Calcite parser is designed to be extensible. I tried multiple approaches and didn't find a way to modify function defined in `Parser.jj`. The closest try is to add a new signature as `builtinFunctionCallMethods`, but that is too late as it is injected after `DateTruncFunctionCall()`. Not sure if it is a Calcite bug because IMO the `builtinFunctionCallMethods` should be injected before parsing it with the default implementations -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
