gortiz commented on code in PR #12704: URL: https://github.com/apache/pinot/pull/12704#discussion_r1546149252
########## pinot-common/src/main/java/org/apache/pinot/common/datablock/BaseDataBlock.java: ########## @@ -71,9 +71,6 @@ * +-----------------------------------------------+ * | VARIABLE_SIZE_DATA SECTION | * +-----------------------------------------------+ - * | METADATA LENGTH | - * | METADATA SECTION | - * +-----------------------------------------------+ Review Comment: This wasn't useful. All blocks but metadata blocks left this empty and in metadata blocks the content was equivalent to variable_size_data, but codified as a single string. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
