gortiz commented on PR #12808: URL: https://github.com/apache/pinot/pull/12808#issuecomment-2046628265
> I feel we can remove the method level `synchronize` and declare the field as `volatile` ? I think that would be safe as well, although the reasoning may be a bit more complex. Given the catastrophic impact of being wrong, I think it is safer to use synchronize. At least, while we are not using virtual threads, it should be fairly cheap. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
