abhioncbr commented on code in PR #12866: URL: https://github.com/apache/pinot/pull/12866#discussion_r1559826386
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/vector/lucene95/HnswVectorsFormat.java: ########## @@ -19,10 +19,10 @@ package org.apache.pinot.segment.local.segment.creator.impl.vector.lucene95; import java.io.IOException; +import org.apache.lucene.backward_codecs.lucene95.Lucene95HnswVectorsFormat; Review Comment: > Does this mean after upgrading Lucece to 0.9.10: > > 1. We can only write index with lucene99 based codecs? True, after upgrading Lucece to 0.9.10, we can only write an index based on lucene99. > 2. If a new generated index is served by an old server (running Lucene 9.8.0), will it break? I am unsure, but I will say it will break if I have to guess. The only thing is this vector functionality (classes) got added in Pinot on Dec/23, so I am not sure how much it is getting used. Maybe @xiangfu0 can help us here with a better understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
