gviedma commented on issue #12676: URL: https://github.com/apache/pinot/issues/12676#issuecomment-2052699309
I have published a set of guidelines along with examples in the [following doc](https://docs.google.com/document/d/1kDggVzD1xR2gy0Rwj97-IPHFKjtS876_VIlBsI0Qeas/edit#heading=h.haf9utbthphk): Please review and leave comments when you get a chance. Once we have enough consensus we can reference this doc from the [Contributing Guidelines](https://github.com/apache/pinot/blob/master/CONTRIBUTING.md#external-libraries). FYI @gortiz I attempted to incorporate your BOM subproject idea and import it from the Pinot POM, but that is explicitly disallowed by [Maven's dependency management](https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html#Importing_Dependencies): > Do not attempt to import a POM that is defined in a submodule of the current POM. Attempting to do that will result in the build failing since it won't be able to locate the POM. I will follow up with you separately on this and to ensure I captured your plugin dependency suggestions correctly in my doc. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
