Jackie-Jiang commented on code in PR #12922:
URL: https://github.com/apache/pinot/pull/12922#discussion_r1575173156
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunctionTest.java:
##########
@@ -116,6 +145,90 @@ public void testCaseTransformFunctionWithIntResults() {
}
}
+ @Test
+ public void testCaseTransformFunctionWithoutCastForFloatValues() throws
Exception {
+ Map<String, DataSource> dataSourceMap = new HashMap<>();
+ int numRows = 1;
+ final int[] intSVValues = new int[numRows];
Review Comment:
(minor, convention) we don't usually put `final` for local variable
##########
pinot-core/src/test/java/org/apache/pinot/core/operator/transform/function/CaseTransformFunctionTest.java:
##########
@@ -116,6 +145,90 @@ public void testCaseTransformFunctionWithIntResults() {
}
}
+ @Test
+ public void testCaseTransformFunctionWithoutCastForFloatValues() throws
Exception {
Review Comment:
(formatting) Can you reformat the changes with [Pinot
Style](https://docs.pinot.apache.org/developers/developers-and-contributors/code-setup#set-up-ide)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
