xiangfu0 commented on code in PR #12940:
URL: https://github.com/apache/pinot/pull/12940#discussion_r1577855082
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java:
##########
@@ -766,6 +767,10 @@ private String composeTableGaugeName(final String
tableName, final String key, f
return gauge.getGaugeName() + "." + getTableName(tableName) + "." + key;
}
+ public String composePluginGaugeName(String pluginName, Gauge gauge) {
+ return pluginName + StringUtils.capitalize(gauge.getGaugeName());
Review Comment:
do you want to add a dot int between ?
`pluginName + "." + StringUtils.capitalize(gauge.getGaugeName());`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
