gortiz commented on PR #12955: URL: https://github.com/apache/pinot/pull/12955#issuecomment-2076503675
> How about we introducing a util which takes the pipe format mailbox id and convert it to the pretty format? Then we can use it when we want a nicer message. I think that goes against the idea you explained in the first comment and in fact that is similar to what this PR does. IICU your first comment, you indicated that you think in the future we may change the format of the mailbox id to something that does not carry the same information. If that is the case, we cannot assume that in the future we are going to be able to extract, from the mailbox id, the stage and other information that can be useful in the messages. Maybe what you wanted to say is that we may want to change the format (but not the content) of the mailbox id in the future. In that case this current proposed implementation is fine because this PR does not modify the format used to send the mailbox id in the binary protocol. Instead it keeps in memory a MailboxId object but when it is serialized/deserialized it is converted to the current string form. So instead of having to use a util to extract a human description from the current mailbox id, this PR extracts the information beforehand when the message is deserialized and keeps it in memory. Given the information carried by the mailbox id is mostly integers, this object representation is probably more memory efficient than the String and it is for sure easier to read (for example, having a `List<MailboxId>` is easier to understand than `List<String>`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
