gortiz commented on code in PR #12783: URL: https://github.com/apache/pinot/pull/12783#discussion_r1579078554
########## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/SortOperator.java: ########## @@ -129,16 +128,19 @@ private TransferableBlock produceSortedBlock() { return TransferableBlockUtils.getEndOfStreamTransferableBlock(); } } else { - LinkedList<Object[]> rows = new LinkedList<>(); - while (_priorityQueue.size() > _offset) { - Object[] row = _priorityQueue.poll(); - rows.addFirst(row); - } - if (rows.size() == 0) { + int resultSize = _priorityQueue.size() - _offset; + if (resultSize == 0) { return TransferableBlockUtils.getEndOfStreamTransferableBlock(); - } else { - return new TransferableBlock(rows, _dataSchema, DataBlock.Type.ROW); } + ArrayList<Object[]> rows = new ArrayList<>(resultSize); + for (int i = 0; i < resultSize; i++) { Review Comment: There we will also have the polymorphic call, but I guess it would be better than the linked list we have right now -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org