klsince commented on code in PR #13017:
URL: https://github.com/apache/pinot/pull/13017#discussion_r1583511926
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/request/RequestUtils.java:
##########
@@ -89,12 +91,13 @@ public static void setOptions(SqlNodeAndOptions
sqlNodeAndOptions, JsonNode json
}
}
if (jsonRequest.has(CommonConstants.Broker.Request.QUERY_OPTIONS)) {
- Map<String, String> queryOptionsFromJson =
RequestUtils.getOptionsFromJson(jsonRequest,
- CommonConstants.Broker.Request.QUERY_OPTIONS);
+ Map<String, String> queryOptionsFromJson =
+ RequestUtils.getOptionsFromJson(jsonRequest,
CommonConstants.Broker.Request.QUERY_OPTIONS);
queryOptions.putAll(queryOptionsFromJson);
}
- boolean enableTrace =
jsonRequest.has(CommonConstants.Broker.Request.TRACE) && jsonRequest.get(
- CommonConstants.Broker.Request.TRACE).asBoolean();
+ boolean enableTrace =
Review Comment:
did we get a new coding style? or those files were just too old and not
reformatted with newer styles.
looks like there are quite a few format changes in this PR. consider to land
them separately?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
