Jackie-Jiang commented on code in PR #13040:
URL: https://github.com/apache/pinot/pull/13040#discussion_r1586682821
##########
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BrokerRequestHandlerDelegate.java:
##########
@@ -85,24 +84,22 @@ public BrokerResponse handleRequest(JsonNode request,
@Nullable SqlNodeAndOption
@Nullable RequesterIdentity requesterIdentity, RequestContext
requestContext, @Nullable HttpHeaders httpHeaders)
throws Exception {
requestContext.setBrokerId(_brokerId);
+
+ // Parse the query if needed
if (sqlNodeAndOptions == null) {
try {
- sqlNodeAndOptions =
RequestUtils.parseQuery(request.get(CommonConstants.Broker.Request.SQL).asText(),
request);
+ sqlNodeAndOptions =
RequestUtils.parseQuery(request.get(Request.SQL).asText(), request);
} catch (Exception e) {
- LOGGER.info("Caught exception while compiling SQL: {}, {}", request,
e.getMessage());
-
_brokerMetrics.addMeteredGlobalValue(BrokerMeter.REQUEST_COMPILATION_EXCEPTIONS,
1);
Review Comment:
We count query planning phase (in v1 the step of converting SqlNode to
PinotQuery) as request compilation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
