gortiz commented on code in PR #13087: URL: https://github.com/apache/pinot/pull/13087#discussion_r1590946437
########## pinot-plugins/pinot-stream-ingestion/pinot-kafka-2.0/src/main/java/org/apache/pinot/plugin/stream/kafka20/KafkaConfigBackwardCompatibleUtils.java: ########## @@ -35,11 +35,13 @@ private KafkaConfigBackwardCompatibleUtils() { */ public static void handleStreamConfig(StreamConfig streamConfig) { Map<String, String> streamConfigMap = streamConfig.getStreamConfigsMap(); + //FIXME: This needs to be done because maven shade plugin also overwrites the constants in the classes + String prefixToReplace = KAFKA_COMMON_PACKAGE_PREFIX.replace(PINOT_SHADED_PACKAGE_PREFIX, ""); Review Comment: Just to give readers some context, this is what `javap` shows for this line before shading: ``` 36: ldc #9 // String org.apache.kafka.common 38: ldc #10 // String org.apache.pinot.shaded. 40: ldc #11 // String 42: invokevirtual #12 // Method java/lang/String.replace:(Ljava/lang/CharSequence;Ljava/lang/CharSequence;)Ljava/lang/String; ``` And this is what it shows after shading: ``` 36: ldc #19 // String org.apache.pinot.shaded.org.apache.kafka.common 38: ldc #22 // String org.apache.pinot.shaded. 40: ldc #60 // String 42: invokevirtual #66 // Method java/lang/String.replace:(Ljava/lang/CharSequence;Ljava/lang/CharSequence;)Ljava/lang/String; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org