vvivekiyer commented on code in PR #13104: URL: https://github.com/apache/pinot/pull/13104#discussion_r1592975672
########## pinot-core/src/main/java/org/apache/pinot/core/transport/AsyncQueryResponse.java: ########## @@ -152,12 +153,6 @@ void receiveDataTable(ServerRoutingInstance serverRoutingInstance, DataTable dat ServerResponse response = _responseMap.get(serverRoutingInstance); response.receiveDataTable(dataTable, responseSize, deserializationTimeMs); - // Record query completion stats immediately after receiving the response from the server instead of waiting Review Comment: Good observation. I see this resulting in more time taken to warm up/ramp up - that's the reason we had this piece of code earlier. With this approach, we'll be more conservative to not overload servers (because we assume that every server has not responded till the last server responds). Achieving both will be a hairier change - considering the interaction between netty/jetty. We can revisit this logic depending on the behavior we see in our environment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org