Jackie-Jiang commented on code in PR #12659:
URL: https://github.com/apache/pinot/pull/12659#discussion_r1596061999
##########
pom.xml:
##########
@@ -237,6 +237,7 @@
<!-- Solve conflict across dependencies -->
<kotlin.stdlib.version>1.9.24</kotlin.stdlib.version>
+ <flink.version>1.19.0</flink.version>
Review Comment:
This variable is already defined above
##########
pom.xml:
##########
@@ -1448,15 +1449,27 @@
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-clients_${scala.compat.version}</artifactId>
+ <artifactId>flink-clients</artifactId>
<version>${flink.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.apache.flink</groupId>
- <artifactId>flink-streaming-java_${scala.compat.version}</artifactId>
+ <artifactId>flink-streaming-java</artifactId>
<version>${flink.version}</version>
</dependency>
+ <dependency>
+ <groupId>org.apache.flink</groupId>
+ <artifactId>flink-java</artifactId>
+ <version>${flink.version}</version>
+ <exclusions>
+ <!-- excluding Kryo library due to Maven Enforcer convergence error
-->
+ <exclusion>
+ <groupId>com.esotericsoftware.kryo</groupId>
Review Comment:
Can you take a look at which library pulls the same dependency and is
causing conflict?
The best practice is to explicitly set the version for this library so that
we won't run into issue (e.g. ClassNotFound) when only `flink` is included but
not the other library that pulls this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
