KKcorps commented on code in PR #13113:
URL: https://github.com/apache/pinot/pull/13113#discussion_r1597908644
##########
pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisConfig.java:
##########
@@ -36,7 +36,7 @@ public class KinesisConfig {
private static final Logger LOGGER =
LoggerFactory.getLogger(KinesisConfig.class);
public static final String STREAM_TYPE = "kinesis";
- public static final String SHARD_ITERATOR_TYPE = "shardIteratorType";
+ public static final String INIT_SHARD_ITERATOR_TYPE =
"initShardIteratorType";
Review Comment:
I will call it out but this config was not being used at all till now since
we always used AFTER_SEQUENCE_NUMBER. And since it is part of stream config
map so won't break table configs as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
