yashmayya opened a new pull request, #13145: URL: https://github.com/apache/pinot/pull/13145
- Non-constant string concatenations are evaluated at runtime even when the actual log message isn't emitted and this has a non-zero performance impact. - Using parameterized log messages helps avoid this issue since the string evaluation will only occur if the logger is enabled. - While this change is particularly impactful for `debug` and `trace` log messages since the default log level is `info`, we should ideally use parameterized log messages instead of string concatenation for all log levels since log levels for loggers can be adjusted, and parameterized log messages are considered best practice. - This patch doesn't modify log messages that are inside a log level check if block ([here](https://github.com/apache/pinot/blob/7ccd2164018505a25c1f91de437088f730e969ec/pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/utils/BlockingMultiStreamConsumer.java#L96-L98), for instance). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
