klsince commented on code in PR #12440: URL: https://github.com/apache/pinot/pull/12440#discussion_r1600485846
########## pinot-spi/src/main/java/org/apache/pinot/spi/env/PropertyIOFactoryKind.java: ########## @@ -0,0 +1,55 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.spi.env; + +import org.apache.commons.configuration2.PropertiesConfiguration; + +public enum PropertyIOFactoryKind { + ConfigFileIOFactory { + public String toString() { + return "ConfigFile"; + } + + @Override + public ConfigFilePropertyIOFactory getInstance() { + return new ConfigFilePropertyIOFactory(); + } + }, + SegmentMetadataIOFactory { + public String toString() { + return "SegmentMetadata"; + } + @Override + public SegmentMetadataPropertyIOFactory getInstance() { + return new SegmentMetadataPropertyIOFactory(); + } + }, + DefaultPropertyConfigurationIOFactory { Review Comment: nit: just DefaultIOFactory for short? ########## pinot-spi/src/main/java/org/apache/pinot/spi/env/CommonsConfigurationUtils.java: ########## @@ -43,28 +46,16 @@ */ public class CommonsConfigurationUtils { private static final Character DEFAULT_LIST_DELIMITER = ','; + public static final String VERSION_HEADER_IDENTIFIER = "version"; Review Comment: To be generic, should we rename the SegmentMetadataIOFactory to something like VersionedIOFactory? so that it's not just for reading/writing SegmentMetadata files. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
