gortiz commented on code in PR #13174: URL: https://github.com/apache/pinot/pull/13174#discussion_r1605141246
########## pinot-query-planner/src/test/resources/log4j2.xml: ########## @@ -0,0 +1,45 @@ +<?xml version="1.0" encoding="UTF-8"?> +<!-- + + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. + +--> +<Configuration> + + <Properties> + <Property name="LOG_PATTERN">%d{yyyy/MM/dd HH:mm:ss.SSS} %p [%c{1}] [%t] %m%n</Property> + </Properties> + <Appenders> + <Console name="console" target="SYSTEM_OUT"> + <PatternLayout pattern="${env:LOG_PATTERN}"/> + </Console> + </Appenders> + <Loggers> + <Root level="info" additivity="false"> + <AppenderRef ref="console"/> + </Root> + <AsyncLogger name="org.reflections" level="error" additivity="false"/> + <Logger name="org.apache.calcite.plan.RelOptPlanner" level="debug" additivity="false"> +<!-- Change FULL_PLAN marker from onMatch="DENY" to onMatch='ACCEPT" to see the full plan before and after each + rule that modifies the plan is applied --> +<!-- <MarkerFilter marker="FULL_PLAN" onMatch="ACCEPT" onMismatch="NEUTRAL"/>--> + <MarkerFilter marker="FULL_PLAN" onMatch="DENY" onMismatch="NEUTRAL"/> + <AppenderRef ref="console"/> Review Comment: I found this very useful to actually see what was going on in the rules. ACCEPT is better, but very verbose. I think it could be useful to have in our CI tests, but I will use DENY for a while to be sure we don't spam too much. BTW, with this log I discovered that `PinotRelDistributionTraitRule` is being applied multiple times, which may introduce some extra latency in very large plans. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
