xiangfu0 commented on code in PR #13146:
URL: https://github.com/apache/pinot/pull/13146#discussion_r1608031397
##########
pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/AggregationFunctionFactory.java:
##########
@@ -47,11 +49,16 @@ public class AggregationFunctionFactory {
private AggregationFunctionFactory() {
}
+ public static AggregationFunction getAggregationFunction(FunctionContext
function, boolean nullHandlingEnabled) {
+ return getAggregationFunction(function, false, nullHandlingEnabled);
+ }
+
/**
* Given the function information, returns a new instance of the
corresponding aggregation function.
* <p>NOTE: Underscores in the function name are ignored in V1.
*/
- public static AggregationFunction getAggregationFunction(FunctionContext
function, boolean nullHandlingEnabled) {
+ public static AggregationFunction getAggregationFunction(FunctionContext
function, boolean isDistinct,
Review Comment:
Reverted `getAggregationFunction` signature, it means we need to have
special handle for `LISTAGG` to append `isDistinct` to the third argument.
This is due to `LISTAGG` is registered in `SqlStdOperatorTable`, so the sql
syntax cannot be changed, usage can only be `LISTAGG(distinct expr, ' | ')` not
`LISTAGG(expr, ' | ', true)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
