Jackie-Jiang commented on code in PR #13103:
URL: https://github.com/apache/pinot/pull/13103#discussion_r1617779412
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/FieldSpec.java:
##########
@@ -98,6 +100,10 @@ public abstract class FieldSpec implements
Comparable<FieldSpec>, Serializable {
}
}
+ public enum MaxLengthExceedStrategy {
+ TRIM_LENGTH, FAIL_INGESTION, SUBSTITUTE_DEFAULT_VALUE, NO_ACTION
Review Comment:
None of them can accurately describe the end-user behavior because it is a
module within the ingestion pipeline, and the end-user behavior also relies on
other configs (especially `continueOnError` flag). IMO we should explain the
expected behavior in the documentation, and put the expected behavior of the
module here to reduce confusion. `THROW_EXCEPTION` might be a little bit java
specific, maybe `ERROR`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
