xiangfu0 opened a new pull request, #13254:
URL: https://github.com/apache/pinot/pull/13254

   Introduced 
https://github.com/apache/pinot/pull/13122/files#diff-7c6118ecbf342922f9e9288c5fbaf9c8dd3f158895d2a7e4e5582762249ecd06R54
   
   We shouldn't set swagger hostname as localhost, which might not be 
accessible from the external environment.
   
   E.g. pinot deployed in k8s will using `pinot-controller-1` as lcoalhost 
name, but this hostname is not exposed outside.
   
   Current Behavior is using machine hostname:
   <img width="608" alt="image" 
src="https://github.com/apache/pinot/assets/1202120/b6a03dab-55d9-4f88-994c-1e173788e5ac";>
   
   <img width="1481" alt="image" 
src="https://github.com/apache/pinot/assets/1202120/de84e599-971b-46c3-898c-5a13343819e4";>
   
   After fix:
   <img width="572" alt="image" 
src="https://github.com/apache/pinot/assets/1202120/41a45231-1223-45ad-8dcb-79bead8b5037";>
   
   <img width="1525" alt="image" 
src="https://github.com/apache/pinot/assets/1202120/b3c79643-147b-4267-9cab-a7bb2db063e6";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to