Jackie-Jiang commented on code in PR #13297:
URL: https://github.com/apache/pinot/pull/13297#discussion_r1628489765
##########
pom.xml:
##########
@@ -1395,7 +1389,7 @@
<dependency>
<groupId>net.openhft</groupId>
<artifactId>posix</artifactId>
- <version>2.26ea0</version>
+ <version>2.25ea0</version>
Review Comment:
Is this change intended?
##########
pom.xml:
##########
@@ -224,12 +224,12 @@
<!-- Google Libraries -->
<google.cloud.libraries.version>26.40.0</google.cloud.libraries.version>
- <google.auth.version>1.23.0</google.auth.version>
- <gson.version>2.10.1</gson.version>
- <guava.version>33.1.0-jre</guava.version>
- <google.http-client.version>1.44.1</google.http-client.version>
- <protobuf.version>3.25.2</protobuf.version>
- <grpc.version>1.61.1</grpc.version>
+ <protobuf.version>3.25.2</protobuf.version> <!-- only getting used in
proto compilation plugin -->
+ <grpc.version>1.61.1</grpc.version> <!-- only getting used in proto
compilation plugin -->
Review Comment:
Is there a way to extract these 2 versions from the BOM?
##########
pom.xml:
##########
@@ -1646,7 +1640,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
- <version>3.7.0</version>
+ <version>3.6.3</version>
Review Comment:
Is this change intended?
##########
pom.xml:
##########
@@ -224,12 +224,12 @@
<!-- Google Libraries -->
<google.cloud.libraries.version>26.40.0</google.cloud.libraries.version>
- <google.auth.version>1.23.0</google.auth.version>
- <gson.version>2.10.1</gson.version>
- <guava.version>33.1.0-jre</guava.version>
- <google.http-client.version>1.44.1</google.http-client.version>
- <protobuf.version>3.25.2</protobuf.version>
- <grpc.version>1.61.1</grpc.version>
+ <protobuf.version>3.25.2</protobuf.version> <!-- only getting used in
proto compilation plugin -->
+ <grpc.version>1.61.1</grpc.version> <!-- only getting used in proto
compilation plugin -->
+ <google.findbugs.version>3.0.2</google.findbugs.version>
+ <google.errorprone.version>2.27.1</google.errorprone.version>
Review Comment:
This doesn't match the current version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
