gortiz commented on code in PR #13035:
URL: https://github.com/apache/pinot/pull/13035#discussion_r1628920654
##########
pinot-common/src/main/java/org/apache/pinot/common/metrics/ServerTimer.java:
##########
@@ -54,7 +54,14 @@ public enum ServerTimer implements AbstractMetrics.Timer {
UPSERT_REMOVE_EXPIRED_PRIMARY_KEYS_TIME_MS("milliseconds", false,
"Total time taken to delete expired primary keys based on metadataTTL or
deletedKeysTTL"),
GRPC_QUERY_EXECUTION_MS("milliseconds", false, "Total execution time of a
successful query over gRPC"),
- UPSERT_SNAPSHOT_TIME_MS("milliseconds", false, "Total time taken to take
upsert table snapshot");
+ UPSERT_SNAPSHOT_TIME_MS("milliseconds", false, "Total time taken to take
upsert table snapshot"),
+
+ // Multi-stage
+ HASH_JOIN_CPU_TIME_BUILDING_HASH_TABLE_MS("millis", true),
+ MULTI_STAGE_SERIALIZATION_CPU_TIME_MS("millis", true),
+ MULTI_STAGE_DESERIALIZATION_CPU_TIME_MS("millis", true),
+ RECEIVE_DOWNSTREAM_CPU_TIME_MS("millis", true),
Review Comment:
Also, added javadoc in all new metrics
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
